lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 04 Jul 2009 07:48:59 +0530 From: Jaswinder Singh Rajput <jaswinder@...nel.org> To: Ingo Molnar <mingo@...e.hu> Cc: Alan Cox <alan@...rguk.ukuu.org.uk>, linux-kernel@...r.kernel.org, Andrew Morton <akpm@...ux-foundation.org>, Yinghai Lu <yinghai@...nel.org> Subject: [GIT PULL -tip][PATCH 0/9] MTRR fix trivial style patches On Fri, 2009-07-03 at 18:42 +0200, Ingo Molnar wrote: > * Alan Cox <alan@...rguk.ukuu.org.uk> wrote: > > > A good example of what happens if you don't is > > > > scripts/checkpatch.pl --file arch/x86/kernel/cpu/mtrr/*c > > > > where the core part of the code isn't changed very much even > > though the interfaces completely get reworked. Thus it never gets > > cleaned up and reviewed as a whole. The code works, will probably > > work for years but never gets looked at as a whole and tidied. > > I think even the MTRR code (which is indeed one of the few x86 > places still not fully cleaned up) supports my arguments. > > Look at the averages: > > errors lines of code errors/KLOC > arch/x86/kernel/cpu/mtrr/amd.c 2 120 16.6 > arch/x86/kernel/cpu/mtrr/centaur.c 8 225 35.5 > arch/x86/kernel/cpu/mtrr/cleanup.c 0 1102 0 > arch/x86/kernel/cpu/mtrr/cyrix.c 10 275 36.3 > arch/x86/kernel/cpu/mtrr/generic.c 16 730 21.9 > arch/x86/kernel/cpu/mtrr/if.c 11 428 25.7 > arch/x86/kernel/cpu/mtrr/main.c 50 751 66.5 > arch/x86/kernel/cpu/mtrr/state.c 0 83 0 > By these trivial mtrr cleanup patches: errors arch/x86/kernel/cpu/mtrr/amd.c 0 arch/x86/kernel/cpu/mtrr/centaur.c 0 arch/x86/kernel/cpu/mtrr/cleanup.c 0 arch/x86/kernel/cpu/mtrr/cyrix.c 0 arch/x86/kernel/cpu/mtrr/generic.c 0 arch/x86/kernel/cpu/mtrr/if.c 0 arch/x86/kernel/cpu/mtrr/main.c 0 arch/x86/kernel/cpu/mtrr/state.c 0 The following changes since commit 2137f10fd78ce8540ec4305f4dcd559039444544: Ingo Molnar (1): Merge branch 'perfcounters/urgent' are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/jaswinder/linux-2.6-top.git master Jaswinder Singh Rajput (9): x86: mtrr/amd.c fix trivial style problems x86: mtrr/centaur.c fix style problems x86: mtrr/cleanup.c fix trivial style problems x86: mtrr/cyrix.c fix trivial style problems x86: mtrr/generic.c fix style problems x86: mtrr/if.c fix trivial style problems x86: mtrr/mtrr.h fix trivial style problems x86: mtrr/state.c fix trivial style problems x86: mtrr/main.c fix style problems arch/x86/kernel/cpu/mtrr/amd.c | 7 +- arch/x86/kernel/cpu/mtrr/centaur.c | 127 +++---------------------- arch/x86/kernel/cpu/mtrr/cleanup.c | 18 ++-- arch/x86/kernel/cpu/mtrr/cyrix.c | 30 +++--- arch/x86/kernel/cpu/mtrr/generic.c | 147 +++++++++++++++------------- arch/x86/kernel/cpu/mtrr/if.c | 51 +++++++---- arch/x86/kernel/cpu/mtrr/main.c | 185 +++++++++++++++++++----------------- arch/x86/kernel/cpu/mtrr/mtrr.h | 7 +- arch/x86/kernel/cpu/mtrr/state.c | 20 +++-- 9 files changed, 263 insertions(+), 329 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists