[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 7 Jul 2009 15:58:23 +0300
From: "Michael S. Tsirkin" <mst@...hat.com>
To: Avi Kivity <avi@...hat.com>
Cc: Gregory Haskins <ghaskins@...ell.com>, kvm@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [KVM PATCH v9 2/2] KVM: add iosignalfd support
On Tue, Jul 07, 2009 at 03:56:09PM +0300, Avi Kivity wrote:
> On 07/07/2009 03:48 PM, Michael S. Tsirkin wrote:
>>>>> +
>>>>> + __kvm_io_bus_unregister_dev(bus,&p->dev);
>>>>> + iosignalfd_release(p);
>>>>>
>>>>>
>>>> a single deassign removed multiple irqfds? Looks ugly.
>>>>
>>>>
>>> Avi requested this general concept.
>>>
>>
>> Really? Avi, could you explain? I would think each
>> assign needs to be matched with 1 deassign. No?
>>
>
> Doesn't it follow naturally?
Yes.
> How can a single deassign remove multiple
> fds (unless all were registered with exactly the same arguments)?
> Maybe we should instead detect that the duplicate iosignaldfds are
> registered.
>
> Note that we do need to allow the same fd to be multiple times, but not
> with exactly the same address/match etc.
--
MST
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists