| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 07 Jul 2009 14:16:13 +0100 From: Catalin Marinas <catalin.marinas@....com> To: Parag Warudkar <parag.warudkar@...il.com> Cc: linux-kernel@...r.kernel.org Subject: Re: Possible memory leak in fs/sysfs/bin.c Parag Warudkar <parag.warudkar@...il.com> wrote: > Catalin Marinas <catalin.marinas <at> arm.com> writes: > >> --- a/fs/sysfs/bin.c >> +++ b/fs/sysfs/bin.c >> @@ -164,6 +164,7 @@ static ssize_t write(struct file *file, const char >> __user *userbuf, >> mutex_lock(&bb->mutex); >> >> memcpy(bb->buffer, temp, count); >> + kfree(temp); > > Does the kfree() need to be inside the mutex_lock? Otherwise looks > OK to me. Here's the updated patch: Free the memory allocated by memdup_user() in fs/sysfs/bin.c Commit 1c8542c7bb replaced kmalloc() with memdup_user() in the write() function but also dropped the kfree(temp). The memdup_user() function allocates memory which is never freed. Signed-off-by: Catalin Marinas <catalin.marinas@....com> --- fs/sysfs/bin.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/fs/sysfs/bin.c b/fs/sysfs/bin.c index 9345806..2524714 100644 --- a/fs/sysfs/bin.c +++ b/fs/sysfs/bin.c @@ -171,6 +171,7 @@ static ssize_t write(struct file *file, const char __user *userbuf, if (count > 0) *off = offs + count; + kfree(temp); return count; } -- Catalin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists