linux-kernel - Re: [PATCH] vlynq: remove duplicated #include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 8 Jul 2009 07:50:52 -0400 (EDT)
From:	"Robert P. J. Day" <rpjday@...shcourse.ca>
To:	Florian Fainelli <florian@...nwrt.org>
cc:	Hannes Eder <hannes@...neseder.net>,
	kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Huang Weiyi <weiyi.huang@...il.com>
Subject: Re: [PATCH] vlynq: remove duplicated #include

On Wed, 8 Jul 2009, Florian Fainelli wrote:

> Hi Hannes,
>
> Le Wednesday 08 July 2009 01:54:14 Hannes Eder, vous avez écrit :
> > On Tue, Jul 7, 2009 at 23:36, Florian Fainelli<florian@...nwrt.org> wrote:
> > > Remove duplicated #include('s) in drivers/vlynq/vlynq.c
> >
> > The following little script catches more of these issues, though it
> > might be a bit fragile:
> >
> > #!/bin/bash
> > find . -name "*.c" | \
> > while read file; do
> >     dblinc=$(grep "^#include <" $file | sort | uniq -c | grep -v "^      1
> > ") [ "$dblinc" != "" ] && echo $file: $dblinc
> > done
> >
> > when ran from the linux-2.6 src tree, the output is something like
> > (lines starting with '#' are my annotations):
> >
> > ./mm/slab.c: 3 #include <linux/kmalloc_sizes.h>
> > # this is a false positive
> > ./mm/slqb.c: 2 #include <linux/seq_file.h>
> > # I did not look a this one
> > ./mm/shmem.c: 2 #include <linux/vfs.h>
> > # this is a hit
> > # the rest (about 50 hits) skipped
> >
> > Do you want to investigate this issues?
>
> I will not, at least not now, but Huang (CC'd) might be interested.

  isn't "make includecheck" supposed to identify duplicated includes?
why aren't you using that?

rday
--

========================================================================
Robert P. J. Day                               Waterloo, Ontario, CANADA

        Linux Consulting, Training and Annoying Kernel Pedantry.

Web page:                                          http://crashcourse.ca
Linked In:                             http://www.linkedin.com/in/rpjday
Twitter:                                       http://twitter.com/rpjday
========================================================================