linux-kernel - Re: lib: Export generic atomic64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 9 Jul 2009 11:09:24 +1000
From:	Paul Mackerras <paulus@...ba.org>
To:	Roland Dreier <rdreier@...co.com>
Cc:	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: lib: Export generic atomic64_t functions

Roland Dreier writes:

> The generic atomic64_t implementation in lib/ did not export the
> functions it defined, which means that modules that use atomic64_t
> would not link on platforms (such as 32-bit powerpc).  For example,
> trying to build a kernel with CONFIG_NET_RDS on such a platform would
> fail with:
> 
>     ERROR: "atomic64_read" [net/rds/rds.ko] undefined!
>     ERROR: "atomic64_set" [net/rds/rds.ko] undefined!
> 
> Fix this by exporting the atomic64_t functions to modules.  (I export
> the entire API even if it's not all currently used by in-tree modules to
> avoid having to continue fixing this in dribs and drabs)
> 
> Signed-off-by: Roland Dreier <rolandd@...co.com>

Nice, thanks.

Acked-by: Paul Mackerras <paulus@...ba.org>

Andrew, I think this should be safe to go in 2.6.31.  Could you
include it in your next batch for Linus, or should I send it to him
directly?

Paul.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/