linux-kernel - Re: [PATCH] move mmci-omap-hs's probe function to .devinit.text

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 11 Jul 2009 15:29:20 -0700
From:	David Brownell <david-b@...bell.net>
To:	"Uwe Kleine-König" 
	<u.kleine-koenig@...gutronix.de>
Cc:	Greg KH <gregkh@...e.de>, linux-kernel@...r.kernel.org,
	Jean Pihet <jpihet@...sta.com>,
	Tony Lindgren <tony@...mide.com>,
	Pierre Ossman <drzeus@...eus.cx>, Andy Lowe <alowe@...sta.com>,
	Adrian Hunter <ext-adrian.hunter@...ia.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Madhusudhan Chikkature <madhu.cr@...com>
Subject: Re: [PATCH] move mmci-omap-hs's probe function to .devinit.text

On Saturday 11 July 2009, Uwe Kleine-König wrote:
> An alternative to this patch is using platform_driver_probe instead of
> platform_driver_register plus removing the pointer to the probe function
> from the struct platform_driver.

And that's the preferred fix ... NAK on this one.

In fact its quite rare for any SoC device to be hotpluggable,
so your default stance in such cases should be to switch over
to platform_driver_probe() instead of doing like this.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/