lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 11 Jul 2009 15:47:24 +0530 From: Jaswinder Singh Rajput <jaswinder@...nel.org> To: Jiri Slaby <jirislaby@...il.com> Cc: Julia Lawall <julia@...u.dk>, gregkh@...e.de, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org Subject: Re: [PATCH 5/5] staging/otus: Move a dereference below a NULL test On Sat, 2009-07-11 at 10:17 +0200, Jiri Slaby wrote: > On 07/11/2009 09:51 AM, Julia Lawall wrote: > > diff -u -p a/drivers/staging/otus/wwrap.c b/drivers/staging/otus/wwrap.c > > --- a/drivers/staging/otus/wwrap.c > > +++ b/drivers/staging/otus/wwrap.c > > @@ -1016,12 +1016,13 @@ void kevent(struct work_struct *work) > > { > > struct usbdrv_private *macp = > > container_of(work, struct usbdrv_private, kevent); > > - zdev_t *dev = macp->device; > > + zdev_t *dev; > > > > if (macp == NULL) > > { > > return; > > } > > The test is rather useless here. > Why useless, it should be non-null before setting to dev. But issue is why function name like kevent() is global and who is using it. > > + dev = macp->device; > > Thanks, -- JSR -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists