linux-kernel - Re: [PATCH] Fix markup_oops to work with 32-bit userspace on a 64-bit kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 13 Jul 2009 08:08:22 -0700
From:	Arjan van de Ven <arjan@...radead.org>
To:	Matthew Wilcox <matthew@....cx>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org
Subject: Re: [PATCH] Fix markup_oops to work with 32-bit userspace on a
 64-bit kernel

On Mon, 13 Jul 2009 08:18:19 -0600
Matthew Wilcox <matthew@....cx> wrote:

> 
> A 32-bit perl can't handle 64-bit addresses without using the BigInt
> package.
> 
> Signed-off-by: Matthew Wilcox <willy@...ux.intel.com>

looks sane enuogh to me


Acked-by: Arjan van de Ven <arjan@...ux.intel.com>


Andrew, can you pull this into -mm patch-logistics wise please?


> 
> diff --git a/scripts/markup_oops.pl b/scripts/markup_oops.pl
> index 528492b..8977401 100644
> --- a/scripts/markup_oops.pl
> +++ b/scripts/markup_oops.pl
> @@ -1,6 +1,7 @@
>  #!/usr/bin/perl
>  
>  use File::Basename;
> +use Math::BigInt;
>  
>  # Copyright 2008, Intel Corporation
>  #
> @@ -172,8 +173,8 @@ while (<STDIN>) {
>  	parse_x86_regs($line);
>  }
>  
> -my $decodestart = hex($target) - hex($func_offset);
> -my $decodestop = hex($target) + 8192;
> +my $decodestart = Math::BigInt->from_hex("0x$target") -
> Math::BigInt->from_hex("0x$func_offset"); +my $decodestop =
> Math::BigInt->from_hex("0x$target") + 8192; if ($target eq "0") {
>  	print "No oops found!\n";
>  	print "Usage: \n";
> 


-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/