linux-kernel - Re: [PATCH 1/3] backlight: Allow drivers to update the core, and generate events on changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 14 Jul 2009 13:55:07 +0100
From:	Matthew Garrett <mjg59@...f.ucam.org>
To:	Richard Purdie <rpurdie@...ys.net>
Cc:	linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org,
	lenb@...nel.org, rui.zhang@...el.com, corentincj@...aif.net
Subject: Re: [PATCH 1/3] backlight: Allow drivers to update the core, and
	generate events on changes

On Tue, Jul 14, 2009 at 01:29:33PM +0100, Richard Purdie wrote:

> My main concern is that we don't start getting bug reports of 'missing'
> events and have clearly defined expectations of when we see what kind of
> events. For example, should an event be emitted when low battery causes
> the backlight to be limited? How about console blanking events turning
> off the backlight? Are there any other occasions we should be emitting
> change events and do we need to audit other drivers?

These are all good questions. I'm working through the drivers now, and 
there's definitely a few more that need doing.

> Also, are "userspace" and "kernel" as meaningful as they could be? Would
> "sysfs" and "hwkeys" make more sense and allow for other future hardware
> differences? Perhaps someone will tie the backlight to an ambient light
> sensor for example...

Yes, though we'd need to extend the interface slightly in that case to 
allow the information to be provided. The ALS case is a good one - if 
that ends up happening in-kernel then there probably shouldn't be a 
UI update.

-- 
Matthew Garrett | mjg59@...f.ucam.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/