| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 14 Jul 2009 12:17:29 +0530 From: Trilok Soni <soni.trilok@...il.com> To: Daniel Walker <dwalker@...o99.com> Cc: Pavel Machek <pavel@....cz>, Brian Swetland <swetland@...gle.com>, kernel list <linux-kernel@...r.kernel.org> Subject: Re: HTC: touchscreen driver Hi Pavel, On Tue, Jul 14, 2009 at 7:18 AM, Daniel Walker<dwalker@...o99.com> wrote: > On Tue, 2009-07-14 at 00:07 +0200, Pavel Machek wrote: >> On Mon 2009-07-13 22:57:49, Pavel Machek wrote: >> > Hi! >> > >> > I'm looking at synaptic touchscreen driver... who should be listed as >> > an author? >> > >> > Changes I have so far are... >> > >> > checkpatch only has minor complains -- lines over 80 characters -- but >> > the code is _way_ too deeply nested with way too little functions. >> >> Here's better cleanup. But... some functions are still _way_ too big. >> > > I'd put the nesting removal into another patch .. It makes reviewing > more clear, your first patch was already fairly busy .. It would also > make a bisect more fine grained if it lands on one of your patches. Please keep linux-input ML for any updates or when you have single patch ready to submit for review. -- ---Trilok Soni http://triloksoni.wordpress.com http://www.linkedin.com/in/triloksoni -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists