linux-kernel - Re: [PATCH 1/2] tsc2007: remove HR timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 14 Jul 2009 10:00:06 +0200
From:	Richard Röjfors 
	<richard.rojfors.ext@...ean-labs.com>
To:	Thierry Reding <thierry.reding@...onic-design.de>
CC:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	linux-input@...r.kernel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	kwangwoo.lee@...il.com, Trilok Soni <soni.trilok@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 1/2] tsc2007: remove HR timer

On 7/14/09 9:08 AM, Thierry Reding wrote:
> * Dmitry Torokhov wrote:
>> Hi Richard,
>>
>> On Tue, Jun 23, 2009 at 01:54:48PM +0200, Richard Röjfors wrote:
> [...]
>> +static void tsc2007_free_irq(struct tsc2007 *ts)
>> +{
>> +	free_irq(ts->irq, ts);
>> +	if (cancel_delayed_work_sync(&ts->work)) {
>> +		/*
>> +		 * Work was pending, therefore we need to enable
>> +		 * IRQ here to balance the disable_irq() done in the
>> +		 * interrupt handler.
>> +		 */
>> +		enable_irq(ts->irq);
>> +	}
>> +}
> [...]
>> -static int tsc2007_remove(struct i2c_client *client)
>> +static int __devexit tsc2007_remove(struct i2c_client *client)
>>   {
>>   	struct tsc2007	*ts = i2c_get_clientdata(client);
>> -	struct tsc2007_platform_data *pdata;
>> +	struct tsc2007_platform_data *pdata = client->dev.platform_data;
>>
>> -	cancel_delayed_work_sync(&ts->work);
>> +	free_irq(ts->irq, ts);
>> +	if (cancel_delayed_work_sync(&ts->work)) {
>> +		/*
>> +		 * Work was pending, therefore we need to enable
>> +		 * IRQ here to balance the disabel done in the
>> +		 * interrupt handler.
>> +		 */
>> +		enable_irq(ts->irq);
>> +	}
>
> Shouldn't this be tsc2007_free_irq(ts) as well?

Is this really good enough? The work function might re-enable the IRQ.

Isn't it better to look at penstate, we know that the IRQ is enabled if 
the state is UP, else the IRQ is disabled.

--Richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/