| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 15 Jul 2009 12:46:45 +0200 From: Andi Kleen <andi@...stfloor.org> To: Zhang Rui <rui.zhang@...el.com> Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, linux-pm <linux-pm@...ts.linux-foundation.org>, linux-acpi <linux-acpi@...r.kernel.org>, Len Brown <lenb@...nel.org>, Pavel Machek <pavel@...e.cz>, "Rafael J. Wysocki" <rjw@...k.pl>, "Van De Ven, Arjan" <arjan.van.de.ven@...el.com> Subject: Re: [PATCH 8/8] i8042: support device async suspend & shutdown Zhang Rui <rui.zhang@...el.com> writes: > i8042 controller support device async actions. > > If boot option "dev_async_action" is added, > i8042 controller and its child devices can be > suspended/resumed/shutdown asynchronously. > >From a quick look at the i8042 driver it still seems to do a lot of slow actions without actually sleeping or worse holding locks. e.g. the delay loop in i8042_flush() Did you measure how long that one takes? Due to the locks even preempt kernels couldn't do something during that time. The spinlocks are probably needed when the code is executed during interrupts, but perhaps the suspend variant could use a different code path. Perhaps it only makes sense to do this when this code is converted to sleep during delays too? -Andi -- ak@...ux.intel.com -- Speaking for myself only. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists