lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 18 Jul 2009 13:47:13 +0200 From: Pavel Machek <pavel@....cz> To: Tiago Vignatti <tiago.vignatti@...ia.com> Cc: Jesse Barnes <jbarnes@...tuousgeek.org>, Dave Airlie <airlied@...hat.com>, linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/2] vga: implements VGA arbitration on Linux On Tue 2009-07-14 15:57:29, Tiago Vignatti wrote: > Signed-off-by: Tiago Vignatti <tiago.vignatti@...ia.com> > --- Some patch description might be useful. > @@ -0,0 +1,1120 @@ > +/* > + * vgaarb.c > + * > + * (C) Copyright 2005 Benjamin Herrenschmidt <benh@...nel.crashing.org> > + * (C) Copyright 2007 Paulo R. Zanoni <przanoni@...il.com> > + * (C) Copyright 2007, 2009 Tiago Vignatti <vignatti@...edesktop.org> > + * If you have copyright, GPL would be cool. > +struct vga_device { > + struct list_head list; > + struct pci_dev *pdev; > + unsigned int decodes; /* what does it decodes */ > + unsigned int owns; /* what does it owns */ > + unsigned int locks; /* what does it locks */ spelling in comments? And ...how can int tell me what it owns? > + > +static LIST_HEAD(vga_list); > +static DEFINE_SPINLOCK(vga_lock); > +static DECLARE_WAIT_QUEUE_HEAD(vga_wait_queue); > + > +#ifndef __ARCH_HAS_VGA_DEFAULT_DEVICE > +static struct pci_dev *vga_default; > +#endif > + > +static void vga_arb_device_card_gone(struct pci_dev *pdev); > + > +/* Find somebody in our list */ > +static struct vga_device *vgadev_find(struct pci_dev *pdev) > +{ > + struct vga_device *vgadev; > + > + list_for_each_entry(vgadev, &vga_list, list) > + if (pdev == vgadev->pdev) > + return vgadev; > + return NULL; > +} Indent using tabs. checkpatch? -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists