| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 20 Jul 2009 12:57:54 -0700 From: Greg KH <gregkh@...e.de> To: Andi Kleen <andi@...stfloor.org> Cc: Dave Jones <davej@...hat.com>, linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org, virtualization@...ts.osdl.org, Hank Janssen <hjanssen@...rosoft.com> Subject: Re: [patch 00/54] [Announce] Microsoft Hyper-V drivers for Linux On Mon, Jul 20, 2009 at 09:37:12PM +0200, Andi Kleen wrote: > Greg KH <gregkh@...e.de> writes: > > > > It's the "normal" way of cleaning up code. Start with a known-working > > piece of stuff, and incrementally clean it up. > > I have to agree with David. This is essentially unreviewable > in the original state. It would be good if you could > do all the obvious cleanups first and then post a consolidated > series. > > Most "obvious" cleanups should not change the binary, so > you can easily check they are correct by comparing the assembler > code. Unfortunatly, some of these cleanups do change the binary, as they are removing wrapper functions. Anyway, I agree, for a "proper" review, I will show the final, cleaned up version, like normal. But we aren't there just yet, that is why this code is going to live in the staging tree for a while. Give us some time to get it fixed up. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists