linux-kernel - Re: iwl3945: fix LED config option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 21 Jul 2009 00:19:15 +0200
From:	Pavel Machek <pavel@....cz>
To:	reinette chatre <reinette.chatre@...el.com>
Cc:	kernel list <linux-kernel@...r.kernel.org>,
	Trivial patch monkey <trivial@...nel.org>
Subject: Re: iwl3945: fix LED config option

> > diff --git a/drivers/net/wireless/iwlwifi/Kconfig b/drivers/net/wireless/iwlwifi/Kconfig
> > index e092af0..95d9aa5 100644
> > --- a/drivers/net/wireless/iwlwifi/Kconfig
> > +++ b/drivers/net/wireless/iwlwifi/Kconfig
> > @@ -9,6 +9,10 @@ config IWLWIFI
> >  config IWLWIFI_LEDS
> >  	bool "Enable LED support in iwlagn and iwl3945 drivers"
> >  	depends on IWLWIFI
> > +	default y
> 
> This is reasonable.
> 
> > +	---help---
> > +	  Useful to get Wifi LED working at least on Thinkpad notebooks.
> 
> I do not think this says more than what we already have. I actually
> think noting something about a particular platform will increase
> confusion (as in "so where is the option if I have an acer laptop?")
> because this option is needed to get LED support on all platforms. I do
> think what is currently written is sufficient, but if you insist on
> having some text there I think it should be simpler. Something like
> "Select this if you want LED support."

Sounds good. (I really believe it should have _some_ text). Will you
just modify/apply the patch, or should I resent?
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/