linux-kernel - Re: Linux 2.6.27.27

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 29 Jul 2009 16:57:02 +0200
From:	Pavel Machek <pavel@....cz>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Krzysztof Oledzki <olel@....pl>, Troy Moure <twmoure@...pr.net>,
	Greg KH <gregkh@...e.de>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>, stable@...nel.org,
	lwn@....net, Ian Lance Taylor <iant@...gle.com>
Subject: Re: Linux 2.6.27.27


> > > diff --git a/drivers/video/fbmon.c b/drivers/video/fbmon.c
> > > index 5c1a2c0..af4a15c 100644
> > > --- a/drivers/video/fbmon.c
> > > +++ b/drivers/video/fbmon.c
> > > @@ -256,8 +256,8 @@ static void fix_edid(unsigned char *edid, int fix)
> > > 
> > > static int edid_checksum(unsigned char *edid)
> > > {
> > > -	unsigned char i, csum = 0, all_null = 0;
> > > -	int err = 0, fix = check_edid(edid);
> > > +	unsigned csum = 0, all_null = 0;
> > > +	int i, err = 0, fix = check_edid(edid);
> 
> I don't know where the 'char' disappeared, but that was obviously not 
> intended. I just meant to move the 'i' from one line to the other.
> 
> > > 
> > > 	if (fix)
> > > 		fix_edid(edid, fix);
> > 
> > Tested-by: Krzysztof Piotr Oledzki <ole@....pl>
> > 
> > On condition, that you keep "unsigned char" here. ;)
> 
> Indeed. I'll commit the fixed version. Thanks for testing and sorry for 
> the idiot patch.

So... we are going to just work around the gcc bug in the kernel?
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/