linux-kernel - Re: [PATCH] tmio_mmc: Optionally support using platform clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 29 Jul 2009 17:33:08 +0200
From:	pHilipp Zabel <philipp.zabel@...il.com>
To:	Magnus Damm <magnus.damm@...il.com>
Cc:	Guennadi Liakhovetski <g.liakhovetski@....de>,
	Ian Molton <ian@...menth.co.uk>, linux-kernel@...r.kernel.org,
	Magnus Damm <damm@...nsource.se>, akpm@...ux-foundation.org,
	Matt Fleming <matt@...sole-pimps.org>,
	Philip Langdale <philipl@...rt.org>
Subject: Re: [PATCH] tmio_mmc: Optionally support using platform clock

On Wed, Jul 29, 2009 at 5:24 PM, Magnus Damm<magnus.damm@...il.com> wrote:
> On Thu, Jul 30, 2009 at 12:20 AM, pHilipp Zabel<philipp.zabel@...il.com> wrote:
>> On Tue, Jul 28, 2009 at 9:51 AM, Guennadi
>> Liakhovetski<g.liakhovetski@....de> wrote:
>>> If the platform device has a clock associated with the tmio-mmc device,
>>> use it.
>>>
>>> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@....de>
>>> Cc: Magnus Damm <damm@...nsource.se>
>>> ---
>>>
>>> Depends (at least logically) on
>>> http://marc.info/?l=linux-kernel&m=124782904228865&w=2
>>>
>>> Sorry if I forgot anyone who volunteered to help out with MMC patches.
>>>
>>>  drivers/mmc/host/tmio_mmc.c |   21 +++++++++++++++++++++
>>>  drivers/mmc/host/tmio_mmc.h |    3 +++
>>>  include/linux/mfd/tmio.h    |    1 +
>>>  3 files changed, 25 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/drivers/mmc/host/tmio_mmc.c b/drivers/mmc/host/tmio_mmc.c
>>> index c246191..2a01572 100644
>>> --- a/drivers/mmc/host/tmio_mmc.c
>>> +++ b/drivers/mmc/host/tmio_mmc.c
>>> @@ -567,6 +576,11 @@ static int __devinit tmio_mmc_probe(struct platform_device *dev)
>>>                        goto unmap_cnf;
>>>        }
>>>
>>> +       host->clk = clk_get(&dev->dev, pdata->clk_name);
>>
>> Instead of pdata->clk_name, this should be either NULL or better
>> "HCLK" (to differentiate from CLK32, not sure if we want to be able to
>> toggle that, too, in the future).
>> Passing the clock consumer ID via pdata is just wrong and shouldn't be
>> needed with clkdev.
>
> Really? I think that depends on the clock framework implementation.
> Remember that this needs to work on other architectures than just ARM.

Oh, clkdev is an ARM only thing. Maybe it would be worthwile to make
this even more generic instead?

regards
Philipp
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/