linux-kernel - Re: [RFC][patch 02/12] remove clocksource inline functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 29 Jul 2009 08:52:50 -0700
From:	Daniel Walker <dwalker@...o99.com>
To:	Martin Schwidefsky <schwidefsky@...ibm.com>
Cc:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>,
	john stultz <johnstul@...ibm.com>
Subject: Re: [RFC][patch 02/12] remove clocksource inline functions

On Wed, 2009-07-29 at 17:32 +0200, Martin Schwidefsky wrote:
> Hmm, you have an object of type struct clocksource and you do
> cs->read(cs). If that is not clear enough then I don't know what is.

It's not as clear as it could be .. In the case above you have to look
in at least two places to know what's going on.. First to see the
cs->read() , and second to see if "cs" is actually a clocksource or
something else.. "cs" could be declared anyplace with any name.

If you see clocksource_read(cs) , you might need to once check what
clocksource_read() is actually doing, but only once.. After that when
you see that function you know that variable is a clocksource, and it's
"read()" is getting called. So you only need to review one line in the
simplest case.

Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/