linux-kernel - Re: [PATCH] [mtd] fixed faulty check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 30 Jul 2009 15:47:47 +0200
From:	Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To:	vimal singh <vimal.newwork@...il.com>
CC:	Stoyan Gaydarov <sgayda2@...c.edu>, linux-kernel@...r.kernel.org,
	David.Woodhouse@...el.com, sr@...x.de, kay.sievers@...y.org,
	gregkh@...e.de, linux-mtd@...ts.infradead.org
Subject: Re: [PATCH] [mtd] fixed faulty check

vimal singh wrote:
> What if you go to 'err_out' due to some other error?? Do not you need
> to free 'info'?
We have to and of_flash_remove() takes care of it.

The initial patch would be shorter if
   dev_set_drvdata(&dev->dev, info);
would be moved prior the kzalloc()

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/