linux-kernel - Re: [PATCH 1/2] power_supply: get_by_name and set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 30 Jul 2009 18:11:34 +0400
From:	Anton Vorontsov <avorontsov@...mvista.com>
To:	Ian Molton <ian@...menth.co.uk>
Cc:	Daniel Mack <daniel@...aq.de>, linux-kernel@...r.kernel.org,
	Anton Vorontsov <cbou@...l.ru>, Matt Reimer <mreimer@...p.net>
Subject: Re: [PATCH 1/2] power_supply: get_by_name and set_charged
	functionality

On Wed, Jul 29, 2009 at 01:45:05PM +0100, Ian Molton wrote:
> Daniel Mack wrote:
> >On Wed, Jul 29, 2009 at 11:29:48AM +0100, Ian molton wrote:
> >>Looks ok. the only comment I have right now is that the comment
> >>doesnt  quite match the patch - it suggests that the patch
> >>doesnt include the  power_supply_set_battery_charged() function,
> >>when it does in fact.
> >
> >The subject mentions it, and the body references it again. Hmm. Anyway.
> >Want me to resend? Or could the commiter add another sentence to point
> >that out? I think that would be Anton, as he agreed to pick all the
> >other patches I recently sent in.
> 
> I'm not that fussed - you just seemed to want feedback, so I had a read ;-)
> 
> If you change it, I'd write something like:
> 
> This adds a function that indicates that a battery is fully charged.
> It also includes functions to get a power_supply device from the
> class of registered devices by name reference. These can be used to
> find a specific battery to call power_supply_set_battery_charged()
> on.
> 
> Some battery drivers might need this information to calibrate
> themselves.

Ian, Matt, much thanks for reviews and acks!
Daniel, thanks for the patches, and for the patience. :-)


Following patches applied to battery-2.6.git (for -next):

Daniel Mack (8):
      ds2760_battery: delay power supply registration
      ds2760_battery: export more features
      ds2760_battery: add rated_capacity module parameter
      ds2760_battery: handle full_active_uAh == 0 case correctly
      ds2760_battery: add current_accum module parameter
      power_supply: EXPORT_SYMBOL cleanups
      power_supply: get_by_name and set_charged functionality
      ds2760_battery: implement set_charged() feature

Let me know if I missed anything.

-- 
Anton Vorontsov
email: cbouatmailru@...il.com
irc://irc.freenode.net/bd2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/