linux-kernel - Re: [PATCH] x86: use online_mask for x2apic target

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 04 Aug 2009 10:13:56 -0700
From:	Suresh Siddha <suresh.b.siddha@...el.com>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: use online_mask for x2apic target_cpus

On Tue, 2009-08-04 at 08:59 -0700, Yinghai Lu wrote:
> found one system with x2apic report:
> [  302.859446] igbvf 0000:81:10.4: enabling device (0000 -> 0002)
> [  302.874369] igbvf 0000:81:10.4: using 64bit DMA mask
> [  302.879023] igbvf 0000:81:10.4: using 64bit consistent DMA mask
> [  302.894386] igbvf 0000:81:10.4: enabling bus mastering
> [  302.898171] igbvf 0000:81:10.4: setting latency timer to 64
> [  302.914050] reserve_memtype added 0xefb08000-0xefb0c000, track uncached-minus, req uncached-minus, ret uncached-minus
> [  302.933839] reserve_memtype added 0xefb28000-0xefb29000, track uncached-minus, req uncached-minus, ret uncached-minus
> [  302.940367]   alloc irq_desc for 265 on node 4
> [  302.956874]   alloc kstat_irqs on node 4
> [  302.959452] alloc irq_2_iommu on node 0
> [  302.974328] igbvf 0000:81:10.4: irq 265 for MSI/MSI-X
> [  302.977778]   alloc irq_desc for 266 on node 4
> [  302.980347]   alloc kstat_irqs on node 4
> [  302.995312] free_memtype request 0xefb28000-0xefb29000
> [  302.998816] igbvf 0000:81:10.4: Failed to initialize MSI-X interrupts.
> 
> it turns out that when trying to enable msi-x.
> __assign_irq_vector(new, cfg_new, apic->target_cpus()) can not get vector
> because for x2apic target-cpus return cpumask_of(0)
> 
> update that to online_mask like xapic.
> 
> Signed-off-by: Yinghai Lu <yinghai@...nel.org>

Acked-by: Suresh Siddha <suresh.b.siddha@...el.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/