linux-kernel - [PATCH] check-dbam1-if-there-is-only-one-DIMM-on-dbam0 in unganged mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 6 Aug 2009 18:44:34 +0800
From:	wan wei <onewayforever@...il.com>
To:	borislav.petkov@....com, dougthompson@...ssion.com
Cc:	linux-kernel@...r.kernel.org
Subject: [PATCH] check-dbam1-if-there-is-only-one-DIMM-on-dbam0 in unganged 
	mode

    When I populated just one DIMM for each of the two channels  of
the cpu node in unganged mode,   there was only one channel found by
edac.
    In counting the channels, if there is only one DIMM found by
dbam0,  i think dbam1 should be checked for the other one  also.
    Below is the patch

Signed-off-by: Wan Wei<wanwei@...ning.com.cn>

---
 drivers/edac/amd64_edac.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c
index e2a10bc..afd210a 100644
--- a/drivers/edac/amd64_edac.c
+++ b/drivers/edac/amd64_edac.c
@@ -1248,7 +1248,7 @@ static int f10_early_channel_count(struct amd64_pvt *pvt)
        /* If more than 2 DIMMs are present, then we have 2 channels */
        if (channels > 2)
                channels = 2;
-       else if (channels == 0) {
+       else if (channels <= 1) {
                /* No DIMMs on DCT0, so look at DCT1 */
                err = pci_read_config_dword(pvt->dram_f2_ctl, DBAM1, &dbam);
                if (err)
-- 
1.4.4.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/