linux-kernel - Re: [alsa-devel] [PATCH][2.6.31-rc5] ARM: OMAP: McBSP: Fix ASoC on OMAP1510 by fixing API of omap_mcbsp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 7 Aug 2009 11:47:57 +0300
From:	Jarkko Nikula <jhnikula@...il.com>
To:	Peter Ujfalusi <peter.ujfalusi@...ia.com>
Cc:	alsa-devel@...a-project.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Janusz Krzysztofik <jkrzyszt@....icnet.pl>,
	Tony Lindgren <tony@...mide.com>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>
Subject: Re: [alsa-devel] [PATCH][2.6.31-rc5] ARM: OMAP: McBSP: Fix ASoC on
 OMAP1510 by fixing API of omap_mcbsp_start/stop

On Fri, 7 Aug 2009 11:30:54 +0300
Peter Ujfalusi <peter.ujfalusi@...ia.com> wrote:

> Looks nice, but I would have done it a bit differently...
> 
...
> > -void omap_mcbsp_start(unsigned int id);
> > -void omap_mcbsp_stop(unsigned int id);
> > +void omap_mcbsp_start(unsigned int id, int tx, int rx);
> > +void omap_mcbsp_stop(unsigned int id, int tx, int rx);
> 
> void omap_mcbsp_start(unsigned int id, int dir);
> void omap_mcbsp_stop(unsigned int id, int dir);
> 
Valid point and cleans up a bit the ALSA SoC part of the patch.
However I didn't want to limit this generic arch/arm/plat-omap/mcbsp.c
into audio use case only. My change still allows to start transmitter
and receiver exactly at the same time. Might be worth if the
generic McBSP driver is used for something else than audio.


-- 
Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/