linux-kernel - Re: [UBI UBIFS] replace vmalloc with kmalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 7 Aug 2009 11:14:57 +0200
From:	Matthieu CASTET <matthieu.castet@...rot.com>
To:	JiSheng Zhang <jszhang3@...il.com>
CC:	"linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
	"Artem.Bityutskiy@...ia.com" <Artem.Bityutskiy@...ia.com>,
	"dwmw2@...radead.org" <dwmw2@...radead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"rmk@....linux.org.uk" <rmk@....linux.org.uk>,
	"adrian.hunter@...ia.com" <adrian.hunter@...ia.com>
Subject: Re: [UBI UBIFS] replace vmalloc with kmalloc

JiSheng Zhang a écrit :
> If nandflash driver use DMA to support UBI and UBIFS i/o, there will
> be panic like
> the following. This is because UBI and UBIFS use vmalloced buffer
> somewhere while
> nandflash driver put the buffer under DMA and DMA support doesn't like vmalloced
> memory.
> [  412.369280] UBIFS: default file-system created
> [  412.374879] Unable to handle kernel NULL pointer dereference at
> virtual address 00000000
> [  412.383177] UBIFS: background thread "ubifs_bgt0_0" started, PID 887
> [  412.389656] pgd = c0004000
> [  412.392419] [00000000] *pgd=00000000
> [  412.396117] Internal error: Oops: 817 [#1] PREEMPT
> 
> Yes, I know kmalloc may fail when memory get fragmented, but I grep the UBI and
> UBIFS's source, there are six .c files and seven .c files using
> vmalloc, the function
> which call vmalloc are all called during the ubi being attached and
> the volume being
> mounted. In embedded system, this mainly happen during kernel boot, it
> should succeed.
> 
> After replacing vmalloc with kmalloc, ubi and ubifs runs fine on my
> board. I can alos upload
> a patch.
> 
> Comments are welcomed!
> 
mtd is not DMA safe. So patching UBI and UBIFS is not enought.


Matthieu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/