linux-kernel - Re: [PATCH v5 1/3] ftrace: add tracepoint for timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 7 Aug 2009 12:56:16 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Xiao Guangrong <xiaoguangrong@...fujitsu.com>
Cc:	Anton Blanchard <anton@...ba.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <peterz@...radead.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>,
	Zhaolei <zhaolei@...fujitsu.com>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 1/3] ftrace: add tracepoint for timer


* Xiao Guangrong <xiaoguangrong@...fujitsu.com> wrote:

> Anton Blanchard wrote:
> > Hi,
> > 
> >> Example ftrace output:
> >>   insmod-1712  [000]   145.901459: timer_init: timer=d0ace4b4
> >>   insmod-1712  [000]   145.901469: timer_start: timer=d0ace4b4 func=timer_fun expires=4294813629 timeout=199
> >>   <idle>-0     [000]   146.100230: timer_cancel: timer=d0ace4b4
> >>   <idle>-0     [000]   146.100233: timer_expire: timer=d0ace4b4 jiffies=4294813629
> >>   <idle>-0     [000]   146.100627: timer_callback_done: func=d0ace4b4
> > 
> > Sorry I haven't followed the thread, but I was wondering why you 
> > changed the name of the entry and exit tracepoints (ie 
> > timer_entry/timer_exit).
> > 
> > I think consistent naming is important to match the other static 
> > tracepoints, such as softirq_entry/softirq_exit, 
> > irq_entry/irq_exit and tasklet_entry/tasklet_exit.
> 
> I rename timer_entry/timer_exit to 
> timer_expire/timer_callback_done just to match this series:
> 
> *_init() -> *_start() -> *_expire()...
> 
> It's a complete timer's lifecycle.

timer _handler_ entry/exit is a pretty good lifecycle name as well - 
and it nicely fits into the irq/softirq naming Anton mentioned. 
Maybe this list:

 timer_init
 timer_start
 timer_expire_entry
 timer_expire_exit
 timer_cancel

works for you Anton?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/