linux-kernel - mISDN: potential null dereference in dsp_cmx_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Date:	Fri, 7 Aug 2009 14:13:42 +0200 (SAST)
From:	Dan Carpenter <error27@...il.com>
To:	isdn@...ux-pingi.de
cc:	linux-kernel@...r.kernel.org
Subject: mISDN: potential null dereference in dsp_cmx_send_member()

Hello,

I am testing a source analysis tool (http://repo.or.cz/w/smatch.git) 
and it generates a warning in dsp_cmx_send_member().

The problem is that on line 1327 we verify that dsp->conf is non null but 
on line 1329 we assume that it is non null and dereference it without 
checking.

drivers/isdn/mISDN/dsp_cmx.c
  1327                  if (dsp->conf && dsp->conf->software && dsp->conf->hardware)
  1328                          tx_data_only = 1;
  1329                  if (dsp->conf->software && dsp->echo.hardware)
  1330                          tx_data_only = 1;

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/