linux-kernel - Re: [PATCH] PM: kill dev_pm_ops platform warning for now

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 8 Aug 2009 15:16:23 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Magnus Damm <magnus.damm@...il.com>, Greg KH <gregkh@...e.de>
Cc:	linux-pm@...ts.linux-foundation.org, lethal@...ux-sh.org,
	stern@...land.harvard.edu, pavel@....cz,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] PM: kill dev_pm_ops platform warning for now

On Friday 07 August 2009, Magnus Damm wrote:
> From: Magnus Damm <damm@...l.co.jp>
> 
> Remove the platform device runtime dev_pm_ops warning
> for now. No point in upsetting users of non-rc kernels.
> 
> Signed-off-by: Magnus Damm <damm@...l.co.jp>

Thanks for the patch, I modified the changelog a bit.

Greg, do you agree with the patch below?

Rafael

---
From: Magnus Damm <damm@...l.co.jp>
Subject: PM / Driver Core: Kill dev_pm_ops platform warning for now

Commit 783ea7d4eeefe895f2731fe73ac951e94418927b
(Driver Core: Rework platform suspend/resume, print warning)
added a warning message printed for platform drivers that use the
legacy PM callbacks rather than struct dev_pm_ops.  Unfortunately,
this resulted in some confusion and made some people try to convert
drivers by replacing the old callbacks with struct dev_pm_ops in
automatic way, which generally is not a good idea.

Remove the platform device runtime dev_pm_ops warning for now,
because it's annoying to users and it's not really necessary right
now.

[rjw: Modified the changelog to be more informative.]

Signed-off-by: Magnus Damm <damm@...l.co.jp>
Signed-off-by: Rafael J. Wysocki <rjw@...k.pl>
---
 drivers/base/platform.c |    3 ---
 1 file changed, 3 deletions(-)

Index: linux-2.6/drivers/base/platform.c
===================================================================
--- linux-2.6.orig/drivers/base/platform.c
+++ linux-2.6/drivers/base/platform.c
@@ -483,9 +483,6 @@ int platform_driver_register(struct plat
 		drv->driver.remove = platform_drv_remove;
 	if (drv->shutdown)
 		drv->driver.shutdown = platform_drv_shutdown;
-	if (drv->suspend || drv->resume)
-		pr_warning("Platform driver '%s' needs updating - please use "
-			"dev_pm_ops\n", drv->driver.name);
 
 	return driver_register(&drv->driver);
 }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/