| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 8 Aug 2009 13:15:00 -0700 From: Josh Triplett <josh@...htriplett.org> To: linux-kernel@...r.kernel.org, xen-devel@...ts.xensource.com Cc: Andrew Morton <akpm@...ux-foundation.org>, Jeremy Fitzhardinge <jeremy@...source.com> Subject: [PATCH] xen: xen_init_cpuid_mask: Zero cx before calling xen_cpuid CPUID function 1 doesn't use cx, but xen_cpuid doesn't know that, resulting in this warning: arch/x86/xen/enlighten.c: In function ‘xen_start_kernel’: arch/x86/xen/enlighten.c:192: warning: ‘cx’ may be used uninitialized in this function arch/x86/xen/enlighten.c:205: note: ‘cx’ was declared here Set cx = 0 to avoid this warning. This seems preferable to implementing a xen_cpuid_nocount without the input constraint for cx, and either of those seem preferable to just ignoring the warning. Signed-off-by: Josh Triplett <josh@...htriplett.org> --- Build-tested only. arch/x86/xen/enlighten.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c index 0a1700a..6ee2ef8 100644 --- a/arch/x86/xen/enlighten.c +++ b/arch/x86/xen/enlighten.c @@ -215,6 +215,7 @@ static __init void xen_init_cpuid_mask(void) (1 << X86_FEATURE_ACPI)); /* disable ACPI */ ax = 1; + cx = 0; xen_cpuid(&ax, &bx, &cx, &dx); /* cpuid claims we support xsave; try enabling it to see what happens */ -- 1.5.6.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists