[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Sat, 8 Aug 2009 08:45:24 +0100
From: Mark Brown <broonie@...nsource.wolfsonmicro.com>
To: Anuj Aggarwal <anuj.aggarwal@...com>
Cc: lrg@...mlogic.co.uk, linux-omap@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 7/8] Regulator: Added board-dependent code for TPS65023
On Fri, Aug 07, 2009 at 08:59:30PM +0530, Anuj Aggarwal wrote:
> + },
> + .num_consumer_supplies = 1,
> + .consumer_supplies = &tps65023_core_consumers,
> + },
This is all OK but as a style thing it's better to use ARRAY_SIZE() for
the number of consumers even if there's just one since that way if
someone adds another consumer they don't need to remember to adjust the
array length.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists