linux-kernel - Re: qi_lb60_keypad driver question?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 12 Aug 2009 10:41:01 +0800
From:	Xiangfu Liu <xiangfu@...hardware.com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
CC:	"Hard- and Software Development, Kernel, Distribution, Roadmap" 
	<developer@...ts.qi-hardware.com>, linux-kernel@...r.kernel.org
Subject: Re: qi_lb60_keypad driver question?

Hi Dmitry Torokhow

thanks for the reply.

Dmitry Torokhov wrote:
> Which is not telling most of the people anything. For example I have no
> idea whta .25 kernel is.
>   
we are current work on 2.6.25.20 kernel. make it work in 'Ben NanoNote' [1]
all the patch is at [2]
> There is already an updated version of matrix_keypad driver in mainline,
> you don't need to repost it.
> This should go into arch specific board setup code, not in drivers/input
>
>   
>> +
>> +static struct platform_device qi_lb60_device = {
>> +	.name		= "qi_lb60-keyboard",
>> +	.name		= "matrix-keypad",
>>     
>
> You are setting .name twice. Also, statically allocated platform devices
> may not be unregistered. Just create this device once in your board init
> code instead of having a separate unloadable module.
>   
thanks for the info.

[1]http://www.qi-hardware.com/products/ben-nanonote/
[2]http://github.com/lindnermarek/openwrt-x-burst/tree/adb28f982f25a822d2dda9aa054470f3fff02908/target/linux/xburst/patches-2.6.25
--
Xiangfu Liu 刘向富
==================================
Qi Hardware Inc.
Mobile: +86 132 4141 2371
Jabber: xiangfu.z at gmail.com
Email : xiangfu at qi-hardware.com
Web   : http://www.qi-hardware.com
==================================

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/