linux-kernel - Re: [ipw3945-devel] mmotm0812 - something in linux-next killed iwl-3945.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 13 Aug 2009 13:28:19 -0400
From:	"John W. Linville" <linville@...driver.com>
To:	Valdis.Kletnieks@...edu
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Zhu Yi <yi.zhu@...el.com>, linux-wireless@...r.kernel.org,
	linux-kernel@...r.kernel.org, ipw3945-devel@...ts.sourceforge.net
Subject: Re: [ipw3945-devel] mmotm0812 - something in linux-next killed
	iwl-3945.c

On Thu, Aug 13, 2009 at 12:59:54PM -0400, Valdis.Kletnieks@...edu wrote:
> Build bombs out:
> 
>   CC      drivers/net/wireless/iwlwifi/iwl-3945.o
> drivers/net/wireless/iwlwifi/iwl-3945.c: In function 'iwl3945_pass_packet_to_mac80211':
> drivers/net/wireless/iwlwifi/iwl-3945.c:580: error: 'hdr' undeclared (first use in this function)
> drivers/net/wireless/iwlwifi/iwl-3945.c:580: error: (Each undeclared identifier is reported only once
> drivers/net/wireless/iwlwifi/iwl-3945.c:580: error: for each function it appears in.)
> make[1]: *** [drivers/net/wireless/iwlwifi/iwl-3945.o] Error 1
> 
> due to this in linux-next.patch:
> 
> index 46288e7..ae7f163 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-3945.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-3945.c
> (skipping)
> @@ -577,7 +577,10 @@ static void iwl3945_pass_packet_to_mac80211(struct iwl_priv
>  *priv,
>         if (ieee80211_is_data(hdr->frame_control))
>                 priv->rxtxpackets += len;
>  #endif
> -       ieee80211_rx_irqsafe(priv->hw, rxb->skb, stats);
> +       iwl_update_stats(priv, false, hdr->frame_control, len);
> +
> +       memcpy(IEEE80211_SKB_RXCB(rxb->skb), stats, sizeof(*stats));
> +       ieee80211_rx_irqsafe(priv->hw, rxb->skb);
>         rxb->skb = NULL;
> 
> Sorry, don't have a linux-next git tree, so no 'git blame' for what did it.
> Hopefully somebody recognizes their handiwork... ;)

I think this is the LEDS-related build failure, which already has a patch.

-- 
John W. Linville		Someday the world will need a hero, and you
linville@...driver.com			might be all we have.  Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/