linux-kernel - Re: [PATCH] fs/proc/task_mmu.c v1: fix clear_refs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 13 Aug 2009 13:12:17 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	Amerigo Wang <xiyou.wangcong@...il.com>
cc:	Vincent Li <macli@....ubc.ca>, linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] fs/proc/task_mmu.c v1: fix clear_refs_write() input
 sanity check

On Thu, 13 Aug 2009, Amerigo Wang wrote:

> >I did the same to other functions, but Andrew pointed out making changes 
> >without fully understanding the patch impact would be risky and break 
> >existing applications, So I need to fully understand what those functions 
> >do before I make any changes.
> > 
> 
> 
> I can't find any strong reason why this one is differernt from others
> in accepting input like "1foo"...
> 

As I already pointed out, there's a patch pending in mmotm that limits the 
write to either 1, 2, or 3, depending on the type of pages the referenced 
bit shall be cleared for associated with the task.

The net effect of Vincent's change is to automatically strip whitespace 
and to remove a needless -EIO error condition at the end of the write 
handler.

It is rather obvious that Vincent's patch is a clear improvement and your 
concern is just a waste of bandwidth.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/