lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 16 Aug 2009 18:31:34 -0700 (PDT) From: David Miller <davem@...emloft.net> To: jens.axboe@...cle.com Cc: linux-kernel@...r.kernel.org, a.p.zijlstra@...llo.nl, fweisbec@...il.com, mingo@...e.hu Subject: Re: [PATCH] basic perf support for sparc From: Jens Axboe <jens.axboe@...cle.com> Date: Thu, 6 Aug 2009 09:02:42 +0200 > On Sun, Aug 02 2009, David Miller wrote: >> From: Jens Axboe <jens.axboe@...cle.com> >> Date: Wed, 29 Jul 2009 13:25:10 +0200 >> >> > -#define NR_SYSCALLS 327 >> > +#define NR_SYSCALLS 328 >> >> When you increase this value, you have to add entries to all of the >> syscall tables. The syscall dispatch checks against this as a limit, >> so if you don't explicitly add an entry to all the tables, it's >> possible to deref garbage past the end of the table and try to jump to >> it as a syscall. > > Oops, missed the 32-bit table. Does the below look better? You got the native 32-bit table, and the native 64-bit table, but you missed sparc64's 32-bit compat syscall table :-) There are two syscall tables in arch/sparc/systbls.S, you only got the native 64-bit one. Please fix this up, and the patch is fine with that cured, so make it a formal submission with commit message and signoffs thanks! > I'm assuming that this will happen automatically at some point, instead > of perf defaulting to building with the same 32/64-bit of the kernel. Right, it looks like Ingo and co. are going to take care of that. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists