linux-kernel - Re: [Patch] proc: drop write permission on 'timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 19 Aug 2009 18:39:59 +0800
From:	Amerigo Wang <amwang@...hat.com>
To:	Wu Fengguang <fengguang.wu@...el.com>
CC:	Li Zefan <lizf@...fujitsu.com>,
	Christoph Lameter <cl@...ux-foundation.org>,
	Pekka Enberg <penberg@...helsinki.fi>,
	Ingo Molnar <mingo@...e.hu>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Vegard Nossum <vegard.nossum@...il.com>,
	Eduard - Gabriel Munteanu <eduard.munteanu@...ux360.ro>,
	Thomas Gleixner <tglx@...utronix.de>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>,
	David Rientjes <rientjes@...gle.com>,
	Matt Mackall <mpm@...enic.com>,
	Arjan van de Ven <arjan@...ux.intel.com>
Subject: Re: [Patch] proc: drop write permission on 'timer_list' and	'slabinfo'

Wu Fengguang wrote:
> On Wed, Aug 19, 2009 at 10:36:30AM +0800, Amerigo Wang wrote:
>   
>> Wu Fengguang wrote:
>>     
>>> On Tue, Aug 18, 2009 at 11:08:30AM +0800, Amerigo Wang wrote:
>>>
>>>   
>>>       
>>>> -	proc_create("slabinfo",S_IWUSR|S_IRUGO,NULL,&proc_slabinfo_operations);
>>>> +	proc_create("slabinfo",S_IRUGO,NULL,&proc_slabinfo_operations);
>>>>     
>>>>         
>>> Style nitpick. The spaces were packed to fit into 80-col I guess.
>>>
>>>   
>>>       
>> Yeah, I noticed this too, the reason I didn't fix this is that I don't 
>> want to mix coding style fix with this one. We can fix it in another 
>> patch, if you want. :)
>>     
>
> Why not? This don't hurt readability of the patch, hehe.
>   

Here we go.

Pekka, could you please also take the patch attached below? It is just a 
trivial coding style fix. And it is based on the my previous patch.

Thanks!


Signed-off-by: WANG Cong <amwang@...hat.com>




View attachment "mm-slub_c-style-fix.diff" of type "text/plain" (916 bytes)