linux-kernel - Re: [PATCH 4/7] kfifo: rename kfifo_put... into kfifo_in... and kfifo_get... into kfifo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 20 Aug 2009 12:28:03 +0100
From:	David Vrabel <david.vrabel@....com>
To:	stefani@...bold.net
CC:	Joe Perches <joe@...ches.com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Arnd Bergmann <arnd@...db.de>,
	Andi Kleen <andi@...stfloor.org>,
	Amerigo Wang <xiyou.wangcong@...il.com>
Subject: Re: [PATCH 4/7] kfifo: rename kfifo_put... into kfifo_in... and kfifo_get...
 into kfifo_out...

stefani@...bold.net wrote:
> Zitat von David Vrabel <david.vrabel@....com>:
> 
>> Joe Perches wrote:
>>> On Wed, 2009-08-19 at 23:00 +0200, Stefani Seibold wrote:
>>>> rename kfifo_put... into kfifo_in... to prevent miss use of old  
>>>> non in kernel-tree drivers
>>>> ditto for kfifo_get... -> kfifo_out...
>>> I would have thought
>>> 	kfifo_put -> kfifo_out
>>> 	kfifo_get -> kfifo_in
>>> but maybe that's just me.
>> Use push and pull instead?  In and out (whichever way) isn't obvious enough.
>>
>> David
>>
> 
> As i wrote before: FIFO means first in/first out not first  
> pushed/first pulled nor first put/first get
> It it logical.

In and out aren't verbs.

David
-- 
David Vrabel, Senior Software Engineer, Drivers
CSR, Churchill House, Cambridge Business Park,  Tel: +44 (0)1223 692562
Cowley Road, Cambridge, CB4 0WZ                 http://www.csr.com/


'member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom'
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/