linux-kernel - Re: 2.6.31-rc5 regression: Oops when USB Serial disconnected while in use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 21 Aug 2009 10:02:51 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
cc:	Bruno Prémont <bonbons@...ux-vserver.org>,
	Greg KH <greg@...ah.com>,
	Kernel development list <linux-kernel@...r.kernel.org>,
	USB list <linux-usb@...r.kernel.org>,
	"Rafael J. Wysocki" <rjw@...k.pl>
Subject: Re: 2.6.31-rc5 regression: Oops when USB Serial disconnected while
 in use

On Thu, 20 Aug 2009, Alan Cox wrote:

> So the tty layer always went that way so that the awkward cases around an
> opening failing with a hangup just go away. For the normal drivers which
> basically do
> 
> open:
> 	tty layer open work
> 		open hardware and set ASYNCB_INITIALIZED
> 	block for carrier
> 
> close:
> 	if (!hung_up) {
> 		if initialized
> 			shutdown()
> 	}
> 
> the USB layer works really hard to be completely different (in part
> because the old code simply didn't implement open semantics properly or
> hangup correctly - hence things like mgetty fail on them).
> 
> The later patches I was working on were trying to get USB serial to the
> point where the model was that drv->open/drv->close were the hardware
> init/shutdown and did indeed get called in nice matching open/close pairs
> and not re-entered or called unserialized.

That is indeed the best approach.  How much is still needed to make it 
work?

> Nice spot on the ASYNC v ASYNCB bug Alan btw

Hah!  Crashing with a big oops was a pretty strong hint that something
was wrong.  The tricky part was grovelling through the disassembly 
listing and figuring out why the offsets were so huge.  :-)

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/