linux-kernel - Re: [Patch] x86: fix a wrong argument of reserve

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 21 Aug 2009 16:39:18 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Amerigo Wang <amwang@...hat.com>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	yinghai@...nel.org
Subject: Re: [Patch] x86: fix a wrong argument of reserve_bootmem()


* Amerigo Wang <amwang@...hat.com> wrote:

> This line looks suspicious, because if this is true, then the 
> 'flags' parameter of function reserve_bootmem_generic() will be 
> unused when !CONFIG_NUMA. I don't think this is what we want.
> 
> Signed-off-by: WANG Cong <amwang@...hat.com>
> Cc: Ingo Molnar <mingo@...e.hu>
> Cc: Yinghai Lu <yinghai@...nel.org>
> 
> ---
> diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
> index 6176fe8..ea56b8c 100644
> --- a/arch/x86/mm/init_64.c
> +++ b/arch/x86/mm/init_64.c
> @@ -796,7 +796,7 @@ int __init reserve_bootmem_generic(unsigned long phys, unsigned long len,
>  		return ret;
>  
>  #else
> -	reserve_bootmem(phys, len, BOOTMEM_DEFAULT);
> +	reserve_bootmem(phys, len, flags);

Yes, this looks like an oversight. Since it only affected 32-bit 
NUMA materially, which is quite rare, it probably didnt matter that 
much but should be fixed ...

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/