linux-kernel - Re: [PATCH 1/1] kcore-use-registerd-physmem-information-fix2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 21 Aug 2009 16:40:16 +0900
From:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
To:	Jiri Slaby <jirislaby@...il.com>
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] kcore-use-registerd-physmem-information-fix2

On Fri, 21 Aug 2009 09:36:08 +0200
Jiri Slaby <jirislaby@...il.com> wrote:

> Fix this compilation warning on x86_64:
> fs/proc/kcore.c: In function ‘kclist_add_private’:
> fs/proc/kcore.c:175: warning: comparison between pointer and integer
> 
Oh, thank you.

Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>


> Signed-off-by: Jiri Slaby <jirislaby@...il.com>
> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
> ---
>  fs/proc/kcore.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/proc/kcore.c b/fs/proc/kcore.c
> index aabbc3a..98fcf17 100644
> --- a/fs/proc/kcore.c
> +++ b/fs/proc/kcore.c
> @@ -172,7 +172,7 @@ kclist_add_private(unsigned long pfn, unsigned long nr_pages, void *arg)
>  		ent->size = ULONG_MAX - ent->addr;
>  
>  	/* cut when vmalloc() area is higher than direct-map area */
> -	if (VMALLOC_START > __va(0)) {
> +	if (VMALLOC_START > (unsigned long)__va(0)) {
>  		if (ent->addr > VMALLOC_START)
>  			goto free_out;
>  		if (VMALLOC_START - ent->addr < ent->size)
> -- 
> 1.6.3.3
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/