linux-kernel - Re: [PATCH resend] vsprintf: use WARN_ON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 23 Aug 2009 21:43:28 +0200
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Marcin Slusarz <marcin.slusarz@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Mike Frysinger <vapier@...too.org>,
	Lai Jiangshan <laijs@...fujitsu.com>
Subject: Re: [PATCH resend] vsprintf: use WARN_ON_ONCE

On Sun, Aug 23, 2009 at 08:28:52PM +0200, Marcin Slusarz wrote:
> From: Marcin Slusarz <marcin.slusarz@...il.com>
> Subject: vsprintf: use WARN_ON_ONCE
> 
> Signed-off-by: Marcin Slusarz <marcin.slusarz@...il.com>


Reviewed-by: Frederic Weisbecker <fweisbec@...il.com>


> 
> diff --git a/lib/vsprintf.c b/lib/vsprintf.c
> index 756ccaf..a63bb18 100644
> --- a/lib/vsprintf.c
> +++ b/lib/vsprintf.c
> @@ -983,13 +983,8 @@ int vsnprintf(char *buf, size_t size, const char *fmt, va_list args)
>  
>  	/* Reject out-of-range values early.  Large positive sizes are
>  	   used for unknown buffer sizes. */
> -	if (unlikely((int) size < 0)) {
> -		/* There can be only one.. */
> -		static char warn = 1;
> -		WARN_ON(warn);
> -		warn = 0;
> +	if (WARN_ON_ONCE((int) size < 0))
>  		return 0;
> -	}
>  
>  	str = buf;
>  	end = buf + size;
> @@ -1439,13 +1434,8 @@ int bstr_printf(char *buf, size_t size, const char *fmt, const u32 *bin_buf)
>  
>  	struct printf_spec spec = {0};
>  
> -	if (unlikely((int) size < 0)) {
> -		/* There can be only one.. */
> -		static char warn = 1;
> -		WARN_ON(warn);
> -		warn = 0;
> +	if (WARN_ON_ONCE((int) size < 0))
>  		return 0;
> -	}
>  
>  	str = buf;
>  	end = buf + size;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/