linux-kernel

Open Source and information security mailing list archives

Date:	Tue, 01 Sep 2009 12:55:23 -0500
From:	Eric Sandeen <sandeen@...deen.net>
To:	Torsten Kaiser <just.for.lkml@...glemail.com>
CC:	Christoph Hellwig <hch@...radead.org>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>,
	Michael Tokarev <mjt@....msk.ru>,
	Linux-kernel <linux-kernel@...r.kernel.org>, xfs@....sgi.com
Subject: Re: xfs compat_ioctl?

Torsten Kaiser wrote:
> On Mon, Aug 31, 2009 at 8:27 PM, Christoph Hellwig<hch@...radead.org> wrote:
>> I think you are right, the constant used is incorrect.  Does the small
>> patch below fix it for you?
> 
> Yes, after adding this patch, xfs_fsr works.

Crud, sorry about that.  I swear I ran 32-bit xfstests under a 64-bit
kernel, but I think we were lacking in fsr coverage....

-Eric

>> Index: linux-2.6/fs/xfs/linux-2.6/xfs_ioctl32.c
>> ===================================================================
>> --- linux-2.6.orig/fs/xfs/linux-2.6/xfs_ioctl32.c       2009-08-31 15:25:06.093044591 -0300
>> +++ linux-2.6/fs/xfs/linux-2.6/xfs_ioctl32.c    2009-08-31 15:25:10.856544216 -0300
>> @@ -619,7 +619,7 @@ xfs_file_compat_ioctl(
>>        case XFS_IOC_GETVERSION_32:
>>                cmd = _NATIVE_IOC(cmd, long);
>>                return xfs_file_ioctl(filp, cmd, p);
>> -       case XFS_IOC_SWAPEXT: {
>> +       case XFS_IOC_SWAPEXT_32: {
>>                struct xfs_swapext        sxp;
>>                struct compat_xfs_swapext __user *sxu = arg;
>>
>>
> 
> _______________________________________________
> xfs mailing list
> xfs@....sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives