linux-kernel - Re: [PATCH 1/2] AB3100 regulator support v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 1 Sep 2009 23:55:35 +0200
From:	Linus Walleij <linus.ml.walleij@...il.com>
To:	Russell King - ARM Linux <linux@....linux.org.uk>
Cc:	Linus Walleij <linus.walleij@...ricsson.com>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Liam Girdwood <lrg@...mlogic.co.uk>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] AB3100 regulator support v2

2009/9/1 Russell King - ARM Linux <linux@....linux.org.uk>:
> On Sun, Aug 30, 2009 at 11:29:09PM +0200, Linus Walleij wrote:
>> This adds support for the regulators found in the AB3100
>> Mixed-Signal IC.
>
> Not sure why I was cc'd on this, but only one comment from me...

For the boardinfo part mainly and for something fun to do when
you're back from your vacation... (welcome back!)

>> +/* Preset (hardware defined) voltages for these regulators */
>> +#define LDO_A_VOLTAGE 2750000
>> +#define LDO_C_VOLTAGE 2650000
>> +#define LDO_D_VOLTAGE 2650000
>> +
>> +int ldo_e_buck_typ_voltages[] = {
>> +     1800000,
>> +     1400000,
>> +     1300000,
>> +     1200000,
>> +     1100000,
>> +     1050000,
>> +     900000,
>> +};
>> +
>> +int ldo_f_typ_voltages[] = {
>> +     1800000,
>> +     1400000,
>> +     1300000,
>> +     1200000,
>> +     1100000,
>> +     1050000,
>> +     2500000,
>> +     2650000,
>> +};
>> +
>> +int ldo_g_typ_voltages[] = {
>> +     2850000,
>> +     2750000,
>> +     1800000,
>> +     1500000,
>> +};
>> +
>> +int ldo_h_typ_voltages[] = {
>> +     2750000,
>> +     1800000,
>> +     1500000,
>> +     1200000,
>> +};
>> +
>> +int ldo_k_typ_voltages[] = {
>> +     2750000,
>> +     1800000,
>> +};
>
> Is there a reason for these to be globally visible?

No. Fixed it and also even made them const * const.

Thanks!

Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/