linux-kernel - Re: [PATCH 5/6] m32r: Move the spi_stack_top and spu_stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 07 Sep 2009 21:30:23 +0900
From:	Hirokazu Takata <takata@...ux-m32r.org>
To:	Tim Abbott <tabbott@...lice.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Sam Ravnborg <sam@...nborg.org>,
	Hirokazu Takata <takata@...ux-m32r.org>
Subject: Re: [PATCH 5/6] m32r: Move the spi_stack_top and spu_stack_top into
 .data section.

From: Tim Abbott <tabbott@...lice.com>
Subject: [PATCH 5/6] m32r: Move the spi_stack_top and spu_stack_top into .data section.
Date: Sun, 06 Sep 2009 23:12:58 -0400
> Since these get squashed into the .data output section by the m32r
> linker script, it seems likely that they don't need their own input
> sections.
> 
> I'd like an explicit confirmation from Hirokazu Takata that this is
> correct (in particular, that there isn't some hidden reason why there
> two structures need to be at the start of the .data output section).

There is no apparent reason.  We've placed them at the start of .data
section, because they are for initial stack region.

I think it would be better that we place them to .init.data section.
Any comment?

> This patch is preparation for cleaning up the m32r architecture to use
> the new macros in vmlinux.lds.h; if these sections are indeed not
> needed, then we can use the RW_DATA_SECTION macro for m32r and save a
> bunch of redundant code.
> 
> Signed-off-by: Tim Abbott <tabbott@...lice.com>
> Cc: Hirokazu Takata <takata@...ux-m32r.org>
> ---
>  arch/m32r/kernel/head.S        |    4 ++--
>  arch/m32r/kernel/vmlinux.lds.S |    2 --
>  2 files changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/m32r/kernel/head.S b/arch/m32r/kernel/head.S
> index 0a71944..fc4d769 100644
> --- a/arch/m32r/kernel/head.S
> +++ b/arch/m32r/kernel/head.S
> @@ -268,13 +268,13 @@ ENTRY(empty_zero_page)
>  /*------------------------------------------------------------------------
>   * Stack area
>   */
> -	.section .spi
> +	.section .data
>  	ALIGN
>  	.global spi_stack_top
>  	.zero	1024
>  spi_stack_top:
>  
> -	.section .spu
> +	.section .data
>  	ALIGN
>  	.global spu_stack_top
>  	.zero	1024
> diff --git a/arch/m32r/kernel/vmlinux.lds.S b/arch/m32r/kernel/vmlinux.lds.S
> index eb3e425..1984b9f 100644
> --- a/arch/m32r/kernel/vmlinux.lds.S
> +++ b/arch/m32r/kernel/vmlinux.lds.S
> @@ -49,8 +49,6 @@ SECTIONS
>  
>    /* writeable */
>    .data : {			/* Data */
> -	*(.spu)
> -	*(.spi)
>  	DATA_DATA
>  	CONSTRUCTORS
>  	}
> -- 
> 1.6.3.3
> 

-- Takata
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/