linux-kernel - Re: [PATCH 2/2] tracing/filters: use strcmp() instead of strncmp()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 09 Sep 2009 09:21:25 +0800
From:	Li Zefan <lizf@...fujitsu.com>
To:	rostedt@...dmis.org
CC:	Frederic Weisbecker <fweisbec@...il.com>,
	Tom Zanussi <tzanussi@...il.com>, Ingo Molnar <mingo@...e.hu>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] tracing/filters: use strcmp() instead of strncmp()

> Not sure this is an issue. I may be a little out of context here, but
> isn't addr coming from the event? The event is made in the kernel and
> should be fine?
> 
> What ever the case, the bug you originally mentioned is still there (I
> just tried it out on the latest tip). That is, name == et will match
> "eth0".
> 

Strange. I fixed it with this commit:

========
commit 7d536cb3fb9993bdcd5a2fbaa6b0670ded4e101c
Author: Li Zefan <lizf@...fujitsu.com>
Date:   Thu Jul 16 10:54:02 2009 +0800

    tracing/events: record the size of dynamic arrays

    When a dynamic array is defined, we add __data_loc_foo in
    trace_entry to record the offset of the array, but the
    size of the array is not recorded, which causes 2 problems:

    - the event filter just compares the first 2 chars of the strings. <-- note here!!

    - parsers can't parse dynamic arrays.

    So we encode the size of each dynamic array in the higher 16 bits
    of __data_loc_foo, while the offset is in lower 16 bits.
========

And I just double checked it to confirm that the bug has been fixed.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/