| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 9 Sep 2009 17:23:49 -0400 From: Ed Cashin <ecashin@...aid.com> To: jens.axboe@...cle.com, ecashin@...aid.com, alan@...rguk.ukuu.org.uk, akpm@...ux-foundation.org, apw@...onical.com, bonbons@...ux-vserver.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] aoe: end barrier bios with EOPNOTSUPP On Wed Sep 9 16:59:30 EDT 2009, jens.axboe@...cle.com wrote: > On Wed, Sep 09 2009, Ed Cashin wrote: ... > > To implement the barrier, [aoe] would stop generating new AoE write > > commands, wait for AoE write responses for all the outstanding write > > commands, issue the ATA cache flush command, wait for the response to > > the flush, and then resume normal activity. > > That's how barriers work with sata to begin with, so I'd very much > recommend that you do the same in aoe instead of just not supporting it. This patch with EOPNOTSUPP just fixes the regression in 2.6.31-rc9. A patch adding support for barriers would be nice. Since I have limited time I tried to motivate that work by using the torture tests that Chris Mason (I believe it was) posted a while ago, but I could not get any problems to manifest using that torture test. If I had a reproducable problem case that the barrier implementation could fix, it would be very helpful. -- Ed -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists