linux-kernel - Re: [patch 00/48] 2.6.27.32-stable review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 8 Sep 2009 20:08:43 -0700
From:	Greg KH <gregkh@...e.de>
To:	Jayson King <dev@...sonking.com>
Cc:	LKML <linux-kernel@...r.kernel.org>, sunil.mushran@...cle.com,
	joel.becker@...cle.com
Subject: Re: [patch 00/48] 2.6.27.32-stable review

On Tue, Sep 08, 2009 at 09:47:51AM -0500, Jayson King wrote:
> Greetings,
> 
> Patch 41/48 (ocfs2: Initialize the...) of this series causes a build 
> failure:
> 
> fs/ocfs2/aops.c: In function ‘ocfs2_write_cluster’:
> fs/ocfs2/aops.c:1286: error: ‘should_zero’ undeclared (first use in this 
> function)
> fs/ocfs2/aops.c:1286: error: (Each undeclared identifier is reported 
> only once
> fs/ocfs2/aops.c:1286: error: for each function it appears in.)
> fs/ocfs2/aops.c: In function ‘ocfs2_write_cluster_by_desc’:
> fs/ocfs2/aops.c:1360: warning: passing argument 4 of 
> ‘ocfs2_write_cluster’ makes pointer from integer without a cast
> fs/ocfs2/aops.c:1360: warning: passing argument 6 of 
> ‘ocfs2_write_cluster’ from incompatible pointer type
> fs/ocfs2/aops.c:1360: warning: passing argument 7 of 
> ‘ocfs2_write_cluster’ makes integer from pointer without a cast
> fs/ocfs2/aops.c:1360: error: too many arguments to function 
> ‘ocfs2_write_cluster’
> 
> 
> A line from the upstream patch is missing in this patch:
> 
>   static int ocfs2_write_cluster(struct address_space *mapping,
>                      u32 phys, unsigned int unwritten,
> +                   unsigned int should_zero,
>                      struct ocfs2_alloc_context *data_ac,
>                      struct ocfs2_alloc_context *meta_ac,
>                      struct ocfs2_write_ctxt *wc, u32 cpos,
>                      loff_t user_pos, unsigned user_len)
> 
> 
> Attached is the corrected patch with the above line placed back in.

There was an add-on ocfs2 patch that should have now resolved this
issue.  If you still have this problem with the released kernel, please
let me know.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/