linux-kernel - [origin tree build failure] [PATCH] block: remove blk_iopoll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 15 Sep 2009 11:28:22 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Jens Axboe <jens.axboe@...cle.com>,
	Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: [origin tree build failure] [PATCH] block: remove
	blk_iopoll_enabled


Note, upstream now breaks the build occasionally if CONFIG_BLOCK is 
disabled:

 kernel/built-in.o:(.data+0x17b0): undefined reference to `blk_iopoll_enabled'

Kamalesh Babulal posted a fix for that two weeks ago, i suspect it 
should be picked up - find it below.

	Ingo

-------------------->
>From 3b049b5e648ebfa508d52e9184d1c6c2cd456a72 Mon Sep 17 00:00:00 2001
From: Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>
Date: Fri, 21 Aug 2009 16:41:13 +0530
Subject: [PATCH] block: remove blk_iopoll_enabled

* Jens Axboe <jens.axboe@...cle.com> [2009-08-07 21:21:44]:

> On Fri, Aug 07 2009, Randy Dunlap wrote:
> > From: Randy Dunlap <randy.dunlap@...cle.com>
> >
> > New block-iopoll sysctl should be surrounded by CONFIG_BLOCK to
> > prevent build error:
> >
> > kernel/built-in.o:(.data+0x2990): undefined reference to `blk_iopoll_enabled'
>
> Thanks, I'll just kill off this sysctl, it should be driver controller
> anyway. Was just easier for testing :-)

This build failure is still seen with next-20090820 kernel, removing
the sysctl helps. Attaching the patch based on your recommendation.
Please drop the patch if you already have in queue.

Signed-off-by: Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>
Cc: Randy Dunlap <randy.dunlap@...cle.com>
Cc: Stephen Rothwell <sfr@...b.auug.org.au>
Cc: akpm <akpm@...ux-foundation.org>
Cc: Jens Axboe <jens.axboe@...cle.com>
LKML-Reference: <20090821111113.GA5105@...ux.vnet.ibm.com>
Signed-off-by: Ingo Molnar <mingo@...e.hu>
--
 kernel/sysctl.c |    8 --------
 1 file changed, 8 deletions(-)
---
 kernel/sysctl.c |    8 --------
 1 files changed, 0 insertions(+), 8 deletions(-)

diff --git a/kernel/sysctl.c b/kernel/sysctl.c
index 6bb59f7..95a1805 100644
--- a/kernel/sysctl.c
+++ b/kernel/sysctl.c
@@ -998,14 +998,6 @@ static struct ctl_table kern_table[] = {
 		.proc_handler	= &proc_dointvec,
 	},
 #endif
-	{
-		.ctl_name	= CTL_UNNUMBERED,
-		.procname	= "blk_iopoll",
-		.data		= &blk_iopoll_enabled,
-		.maxlen		= sizeof(int),
-		.mode		= 0644,
-		.proc_handler	= &proc_dointvec,
-	},
 /*
  * NOTE: do not add new entries to this table unless you have read
  * Documentation/sysctl/ctl_unnumbered.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/