linux-kernel - Re: [PATCH] blackfin: Cleanup linker script using new linker script macros.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 15 Sep 2009 23:13:16 -0400
From:	Mike Frysinger <vapier.adi@...il.com>
To:	Tim Abbott <tabbott@...lice.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Sam Ravnborg <sam@...nborg.org>,
	Bryan Wu <cooloney@...nel.org>,
	uclinux-dist-devel@...ckfin.uclinux.org
Subject: Re: [PATCH] blackfin: Cleanup linker script using new linker script 
	macros.

the larger padding in the initramfs is kind of annoying as i cant see
any need to pad it to PAGE_SIZE.  since the initramfs is released with
the rest of the init section, it doesnt need whole pages.  a quick
test shows that it does waste a few kb in reality.  default build for
BF533-STAMP for example shows 0x1000 difference.

in terms of correctness, this change misses a reference to the now
deleted .init.ramfs:
-       .init.ramfs :
-       {
-       .....
-       }
-
       .text_l1 L1_CODE_START : AT(LOADADDR(.init.ramfs) + SIZEOF(.init.ramfs))

so that .text_l1 needs to updated to refer to the new section before
it (.exit.data in this case).  once i make that change, the resulting
link looks the same (minus the initramfs thing mentioned earlier), and
it does boot.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/