linux-kernel - Re: [PATCH] [1/2] kbuild: Add a really-ld-option macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 19 Sep 2009 10:07:00 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [1/2] kbuild: Add a really-ld-option macro

On Wed, Sep 16, 2009 at 10:36:54PM +0200, Andi Kleen wrote:
> 
> Different from the existing ld macro by checking $(LD)
> 
> Needed for the next patch
> 
> Signed-off-by: Andi Kleen <ak@...ux.intel.com>
> 
> ---
>  scripts/Kbuild.include |    9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> Index: linux-2.6.31-ak/scripts/Kbuild.include
> ===================================================================
> --- linux-2.6.31-ak.orig/scripts/Kbuild.include
> +++ linux-2.6.31-ak/scripts/Kbuild.include
> @@ -83,11 +83,12 @@ TMPOUT := $(if $(KBUILD_EXTMOD),$(firstw
>  # is automatically cleaned up.
>  try-run = $(shell set -e;		\
>  	TMP="$(TMPOUT).$$$$.tmp";	\
> +	TMPO="$(TMPOUT).$$$$.o";	\
>  	if ($(1)) >/dev/null 2>&1;	\
>  	then echo "$(2)";		\
>  	else echo "$(3)";		\
>  	fi;				\
> -	rm -f "$$TMP")
> +	rm -f "$$TMP" "$$TMPO")
>  
>  # as-option
>  # Usage: cflags-y += $(call as-option,-Wa$(comma)-isa=foo,)
> @@ -135,6 +136,12 @@ cc-ifversion = $(shell [ $(call cc-versi
>  ld-option = $(call try-run,\
>  	$(CC) $(1) -nostdlib -xc /dev/null -o "$$TMP",$(1),$(2))
>  
> +# really-ld-option
> +# checks $(LD) unlike ld-option
> +# Usage: LDFLAGS += $(call really-ld-option, -X)
> +really-ld-option = $(call try-run,\
> +	$(CC) /dev/null -c -o "$$TMPO" ; $(LD) $(1) "$$TMPO" -o "$$TMP",$(1),$(2))
> +

kbuild has some strange marcro names - but adding more is no good.
I will:
1) rename ld-option to cc-ldoption
2) add ld-option, and _document_ it in makefiles.txt
3) use ld-option for the -X option

I had preferred your patchset did so.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/