linux-kernel - Re: [Uclinux-dist-devel] [PATCH] input/keyboard: new driver for ADP5520 MFD PMICs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 21 Sep 2009 09:40:46 -0400
From:	Mike Frysinger <vapier.adi@...il.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Michael Hennerich <michael.hennerich@...log.com>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
	uclinux-dist-devel@...ckfin.uclinux.org
Subject: Re: [Uclinux-dist-devel] [PATCH] input/keyboard: new driver for 
	ADP5520 MFD PMICs

On Mon, Sep 21, 2009 at 00:04, Andrew Morton wrote:
> On Sun, 20 Sep 2009 18:40:41 -0400 Mike Frysinger wrote:
>> On Sun, Sep 20, 2009 at 02:30, Andrew Morton wrote:
>> > On Thu, 17 Sep 2009 14:24:10 -0400 Mike Frysinger wrote:
>> >> +struct adp5520_keys {
>> >> + __ __ struct input_dev *input;
>> >> + __ __ struct notifier_block notifier;
>> >> + __ __ struct device *master;
>> >> + __ __ unsigned short keycode[ADP5520_KEYMAPSIZE];
>> >
>> > Where is ADP5520_KEYMAPSIZE defined?
>>
>> all these things are in the common mfd adp5520 patch.  it introduces a
>> common adp5520 header.
>
> err, what common MFD patch?  There was nothing in either the changelog
> nor the patch title which indicated that this patch had a dependency on
> other patches.  This makes things harder for mergers and reviewers,
> especially when the patchset hits multiple subsystems, maintained by
> multiple developers.
>
> Probably the best way to handle this sort of thing is to present it as a
> sequence-numbered patch series with well-chosen cc's and an overall
> description of the dependencies and perhaps the merge plan in [patch
> 0/n].

the MFD patch has been sent to the MFD guy already for review.  being
an MFD means it touches like 4 or 5 different subsystems.  but the
only dependency is on the MFD core.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/