| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 21 Sep 2009 11:31:07 -0400 From: Mike Frysinger <vapier.adi@...il.com> To: Al Viro <viro@...iv.linux.org.uk> Cc: Miklos Szeredi <miklos@...redi.hu>, akpm@...ux-foundation.org, linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, Valdis.Kletnieks@...edu, agruen@...e.de, hch@....de, hugh.dickins@...cali.co.uk, matthew@....cx Subject: Re: [PATCH 2/2] vfs: fix d_path() for unreachable paths On Mon, Sep 21, 2009 at 10:43, Al Viro wrote: > On Mon, Sep 21, 2009 at 03:38:57PM +0100, Al Viro wrote: >> On Mon, Sep 21, 2009 at 10:10:17AM -0400, Mike Frysinger wrote: >> > it works without having to copy & paste the same exact structures over >> > and over. a suggestion as how to do it cleanly without bloating the >> > code is certainly welcome. it doesnt really matter that it's on the >> > stack as the usage is small and d_path() is given the size of the >> > buffer, so it isnt going to overflow. > > PS: as to why it is broken... Consider e.g. > mount --bind /proc/cplbinfo/cpu0 /mnt > cat /mnt/icplb > Or, better yet, > mount -t proc none /mnt/cpu > cat /mnt/cpu/cplbinfo/cpu0/icplb i'm not disagreeing that it doesnt work under all random VFS scenarios. just that the realistic ones all work. -mike -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists